gulfem marked an inline comment as done. gulfem added inline comments.
================ Comment at: clang/test/Sema/attr-leaf.c:4 + +void f() __attribute__((leaf)); ---------------- aaron.ballman wrote: > Can you also add tests that show the attribute diagnoses being written on the > wrong subject or when given arguments? Also, can you add a test showing the > attribute on a function definition with a FIXME comment about wanting to > diagnose that case? I added three more test cases which also includes a test case with FXME comment for function definition diagnosis. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
