craig.topper added a subscriber: bkramer.
craig.topper added inline comments.
================
Comment at: clang/lib/Basic/Targets/X86.cpp:548
break;
- case CK_ZNVER3:
- defineCPUMacros(Builder, "znver3");
----------------
Why is this being deleted?
================
Comment at: clang/lib/Basic/Targets/X86.cpp:1339
case CK_ZNVER2:
- case CK_ZNVER3:
// Deprecated
----------------
Same here?
================
Comment at: compiler-rt/lib/builtins/cpu_model.c:480
break;
+ case 25:
+ *Type = AMDFAM19H;
----------------
I thought this code was already added to compiler-rt by @bkramer
================
Comment at: llvm/test/CodeGen/X86/cpus-amd.ll:30
; RUN: llc < %s -o /dev/null -mtriple=x86_64-unknown-unknown -mcpu=znver2 2>&1
| FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty
-; RUN: llc < %s -o /dev/null -mtriple=x86_64-unknown-unknown -mcpu=znver3 2>&1
| FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty
----------------
Why deleted?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92812/new/
https://reviews.llvm.org/D92812
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
