aeubanks added inline comments.

================
Comment at: llvm/lib/IR/PassTimingInfo.cpp:47
+    cl::desc("Time each pass run, printing elapsed time for each run on exit"),
+    cl::callback([](const bool &) { TimePassesIsEnabled = true; }));
+
----------------
ychen wrote:
> aeubanks wrote:
> > is this necessary?
> Yeah, it is. `TimePassesPerRun` (corresponding to TimePassesHandler::PerRun) 
> is not used if `TimePassesIsEnabled` is false.
Whoops, didn't see that this was touching two separate variables


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92436/new/

https://reviews.llvm.org/D92436

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to