tdl-g added inline comments.
================
Comment at: clang/unittests/Tooling/StencilTest.cpp:513
+TEST(StencilToStringTest, DescribeOp) {
+ auto S = describe("Id");
----------------
ymandel wrote:
> tdl-g wrote:
> > Can you add a comment (or a more detailed test name) explaining what this
> > test case is validating?
> It's the same pattern for (nearly) all of the StencilToStringTest cases.
> Might a comment on the fixture be a better place?
Oh, sorry, I thought the "repr" was a stencil combinator, I didn't realize it
was part of the raw string quotation. My bad.
LGTM as is.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92658/new/
https://reviews.llvm.org/D92658
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
