rjmccall added a comment.

Functionally LGTM.  I don't know if 11 is still taking changes, but if it is, 
you have code-owner approval.



================
Comment at: clang/test/CodeGenObjC/gnu-method-only-once.m:8
+// merging happened was missed in the move and so we ended up emitting two
+// copies of method metadata for everything that appeared in the 
+
----------------
Comment trails off.  Not sure the bug history is necessary here; you could just 
make this part of the commit message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91874/new/

https://reviews.llvm.org/D91874

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to