NoQ accepted this revision. NoQ added a reviewer: vsavchenko. NoQ added a comment. This revision is now accepted and ready to land.
Aha, ok then! Thanks for cleaning this up. Maybe we should provide default initializers for `bool` flags then, so that they weren't undefined by default. ================ Comment at: clang/include/clang/Analysis/PathDiagnostic.h:71 /// without re-compiling the program under analysis. bool ShouldDisplayMacroExpansions; ---------------- ================ Comment at: clang/include/clang/Analysis/PathDiagnostic.h:75 /// Useful for profiling the tool on large real-world codebases. bool ShouldSerializeStats; ---------------- ================ Comment at: clang/include/clang/Analysis/PathDiagnostic.h:85 /// off by default. bool ShouldWriteStableReportFilename; ---------------- ================ Comment at: clang/include/clang/Analysis/PathDiagnostic.h:89 /// Useful for breaking your build when issues are found. bool ShouldDisplayWarningsAsErrors; ---------------- ================ Comment at: clang/include/clang/Analysis/PathDiagnostic.h:93 /// with fix-it hints attached to the diagnostics it consumes. bool ShouldApplyFixIts; ---------------- ================ Comment at: clang/include/clang/Analysis/PathDiagnostic.h:97 /// the diagnostic (eg., a checker) so that the user knew how to disable it. bool ShouldDisplayDiagnosticName; }; ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92221/new/ https://reviews.llvm.org/D92221 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
