ldionne added a comment. In D91311#2417293 <https://reviews.llvm.org/D91311#2417293>, @rsmith wrote:
> In D91311#2416940 <https://reviews.llvm.org/D91311#2416940>, @ldionne wrote: > >> LGTM from the libc++ point of view. The CI is passing -- those failures are >> flaky modules tests that we need to fix. > > Perhaps we need to specify `-fmodules-validate-system-headers` in the test so > Clang doesn't assume that system headers are unchanged? Oh, would that be it? We're not including libc++ headers as system headers when running the tests, though (and we're disabling the system header pragma). Do you think that might still be the issue? I tried a dumb workaround with D92131 <https://reviews.llvm.org/D92131>, but it's arguably not great. I'd love to have your thoughts on that. We've been seeing these issues for a while when we make some types of changes in the `__config_site`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91311/new/ https://reviews.llvm.org/D91311 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
