pengfei added a comment.
> 2. Delete IsPrefix parameter, and delete 'break', so that we won't check
> prefix again. I am not sure if this is right. Att format can allow two prefix
> and using the last one as the finally encoding prefix. I think this may not
> be the original intention of the design.
It allows more than two, right? like `{vex}{vex2}{vex3} instruction`. I think
it should be a bug for att.
================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3079
+ if (ForcedVEXEncoding != VEXEncoding_Default) {
+ if (getLexer().isNot(AsmToken::Identifier))
+ return Error(Parser.getTok().getLoc(), "Expected identifier");
----------------
Do you need to eat the prefix here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90441/new/
https://reviews.llvm.org/D90441
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
