jdoerfert added inline comments.
================
Comment at: clang/lib/CodeGen/CGCall.cpp:2169
+ if (!CodeGenOpts.NullPointerIsValid &&
+ getContext().getTargetAddressSpace(FI.arg_begin()->type) == 0) {
+ Attrs.addAttribute(llvm::Attribute::NonNull);
----------------
arichardson wrote:
> Isn't the `this` pointer also nonnull in other address spaces?
>
> In our CHERI fork we use AS200 for the this pointer and would quite like to
> have the nonnull attribute.
> I can obviously change this line locally when I next merge from upstream, but
> I would like to avoid diffs and it seems to me like this restriction is
> unnecessary.
I also think `NullPointerIsValid` is sufficient.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D17993/new/
https://reviews.llvm.org/D17993
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
