njames93 added inline comments.
================ Comment at: clang-tools-extra/test/clang-tidy/checkers/llvm-include-order.cpp:1 // RUN: %check_clang_tidy %s llvm-include-order %t -- -- -isystem %S/Inputs/Headers ---------------- kadircet wrote: > njames93 wrote: > > Would it be wise to specify a format style here to ensure they align. > > Better yet 2 run lines, one that runs clang-tidy with no format, the other > > specifies a format. > ah sorry, i missed this comment :/ i am not sure how the formatting vs. > generated edits interact. is it enough to have `--format-style=LLVM` and > ensure the run lines produce the same ordering? Just noticed they still don't seem to sync up, but thats because llvm-include-order doesn't move the first include in a file. Could argue that's a bug and instead should use a heuristic based on the translation unit name and header name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91602/new/ https://reviews.llvm.org/D91602 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
