joechrisellis added inline comments.
================ Comment at: clang/lib/Sema/SemaCast.cpp:2217-2218 - // Allow reinterpret_casts between vectors of the same size and - // between vectors and integers of the same size. bool destIsVector = DestType->isVectorType(); ---------------- c-rhodes wrote: > joechrisellis wrote: > > c-rhodes wrote: > > > nit: not sure we need to change this > > I changed this because the code changes mean that the original comment is > > incomplete. I.e., we now allow for reinterpret casts VLAT <-> VLST, which > > is not captured by the comment above. > > I changed this because the code changes mean that the original comment is > > incomplete. I.e., we now allow for reinterpret casts VLAT <-> VLST, which > > is not captured by the comment above. > > It's a minor point but the reason I raised it is we have to be conscious of > the fact most people probably don't care about SVE and this is changing an > existing comment to put it first and foremost. Ok, I see what you mean. Will revert this part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91262/new/ https://reviews.llvm.org/D91262 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
