segoon added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/misc/MtUnsafeCheck.cpp:295
+ case MtUnsafeCheck::LibcType::Any:
+ return hasAnyName(anyFunctions);
+ }
----------------
lebedev.ri wrote:
> return anyOf(hasAnyName(posixFunctions), hasAnyName(glibcFunctions));
It would be a bit slower than now - the current code removes duplicates.
If/when other FunctionSets are added, duplicate list will be much bigger.
================
Comment at: clang-tools-extra/clang-tidy/misc/MtUnsafeCheck.cpp:309-310
+void MtUnsafeCheck::registerMatchers(MatchFinder *Finder) {
+ Finder->addMatcher(callExpr(callee(functionDecl(hasAnyMtUnsafeNames(Libc))))
+ .bind("mt-unsafe"),
+ this);
----------------
lebedev.ri wrote:
> Is there any way to invert the direction of this matcher,
> instead of checking each call that it's callee isn't one of the bad ones,
> look through all function decls, and for all the bad ones, diagnose all calls
> to them?
I'm not sure it is possible without additional costs - it would require somehow
marking bad FunctionDecl, it requires an addition of state.
I'm not an expert in LLVM AST, maybe it is very cheap and easy to do, but I
don't see how, do you?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90944/new/
https://reviews.llvm.org/D90944
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
