abelkocsis added inline comments.
================
Comment at:
clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.cpp:68
+ const SourceManager &SM, Preprocessor *pp, Preprocessor *ModuleExpanderPP)
{
+ PP = pp;
+}
----------------
whisperity wrote:
> Global state is always a potential problem. Are you sure this is the right
> way to do things? Most other tidy checks that actively use this function
> define their own `PPCallback` subclass and use the existing preprocessor here
> to ensure the preprocessor executes the callback.
I've used the same way in another check (https://reviews.llvm.org/D69181). I'm
not entirely sure which is the better way to do.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75229/new/
https://reviews.llvm.org/D75229
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
