This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG52f05fb2c2c3: [MemProf][NewPM] Make memprof passes required
(authored by aeubanks).
Changed prior to commit:
https://reviews.llvm.org/D91389?vs=304965&id=305276#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91389/new/
https://reviews.llvm.org/D91389
Files:
clang/test/CodeGen/no-skipped-passes-O0-opt-bisect.c
llvm/include/llvm/Transforms/Instrumentation/MemProfiler.h
Index: llvm/include/llvm/Transforms/Instrumentation/MemProfiler.h
===================================================================
--- llvm/include/llvm/Transforms/Instrumentation/MemProfiler.h
+++ llvm/include/llvm/Transforms/Instrumentation/MemProfiler.h
@@ -30,6 +30,7 @@
public:
explicit MemProfilerPass();
PreservedAnalyses run(Function &F, FunctionAnalysisManager &AM);
+ static bool isRequired() { return true; }
};
/// Public interface to the memory profiler module pass for instrumenting code
@@ -38,6 +39,7 @@
public:
explicit ModuleMemProfilerPass();
PreservedAnalyses run(Module &M, ModuleAnalysisManager &AM);
+ static bool isRequired() { return true; }
};
// Insert MemProfiler instrumentation
Index: clang/test/CodeGen/no-skipped-passes-O0-opt-bisect.c
===================================================================
--- clang/test/CodeGen/no-skipped-passes-O0-opt-bisect.c
+++ clang/test/CodeGen/no-skipped-passes-O0-opt-bisect.c
@@ -9,6 +9,7 @@
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -enable-npm-optnone -O0
-fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null
-fsanitize=local-bounds 2>&1 | FileCheck %s
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -enable-npm-optnone -O0
-fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null
-fsanitize=dataflow 2>&1 | FileCheck %s
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -enable-npm-optnone -O0
-fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null
-fsanitize-coverage-trace-pc-guard 2>&1 | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -enable-npm-optnone -O0
-fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null
-fmemory-profile 2>&1 | FileCheck %s
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -opt-bisect-limit=0
-fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null
2>&1 | FileCheck %s
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -opt-bisect-limit=0
-fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null
-fcoroutines-ts 2>&1 | FileCheck %s
@@ -19,6 +20,7 @@
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -opt-bisect-limit=0
-fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null
-fsanitize=local-bounds 2>&1 | FileCheck %s
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -opt-bisect-limit=0
-fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null
-fsanitize=dataflow 2>&1 | FileCheck %s
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -opt-bisect-limit=0
-fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null
-fsanitize-coverage-trace-pc-guard 2>&1 | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -opt-bisect-limit=0
-fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null
-fmemory-profile 2>&1 | FileCheck %s
// CHECK-NOT: Skipping pass
Index: llvm/include/llvm/Transforms/Instrumentation/MemProfiler.h
===================================================================
--- llvm/include/llvm/Transforms/Instrumentation/MemProfiler.h
+++ llvm/include/llvm/Transforms/Instrumentation/MemProfiler.h
@@ -30,6 +30,7 @@
public:
explicit MemProfilerPass();
PreservedAnalyses run(Function &F, FunctionAnalysisManager &AM);
+ static bool isRequired() { return true; }
};
/// Public interface to the memory profiler module pass for instrumenting code
@@ -38,6 +39,7 @@
public:
explicit ModuleMemProfilerPass();
PreservedAnalyses run(Module &M, ModuleAnalysisManager &AM);
+ static bool isRequired() { return true; }
};
// Insert MemProfiler instrumentation
Index: clang/test/CodeGen/no-skipped-passes-O0-opt-bisect.c
===================================================================
--- clang/test/CodeGen/no-skipped-passes-O0-opt-bisect.c
+++ clang/test/CodeGen/no-skipped-passes-O0-opt-bisect.c
@@ -9,6 +9,7 @@
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -enable-npm-optnone -O0 -fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null -fsanitize=local-bounds 2>&1 | FileCheck %s
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -enable-npm-optnone -O0 -fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null -fsanitize=dataflow 2>&1 | FileCheck %s
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -enable-npm-optnone -O0 -fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null -fsanitize-coverage-trace-pc-guard 2>&1 | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -enable-npm-optnone -O0 -fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null -fmemory-profile 2>&1 | FileCheck %s
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -opt-bisect-limit=0 -fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null 2>&1 | FileCheck %s
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -opt-bisect-limit=0 -fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null -fcoroutines-ts 2>&1 | FileCheck %s
@@ -19,6 +20,7 @@
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -opt-bisect-limit=0 -fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null -fsanitize=local-bounds 2>&1 | FileCheck %s
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -opt-bisect-limit=0 -fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null -fsanitize=dataflow 2>&1 | FileCheck %s
// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -opt-bisect-limit=0 -fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null -fsanitize-coverage-trace-pc-guard 2>&1 | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -mllvm -opt-bisect-limit=0 -fexperimental-new-pass-manager %s -fdebug-pass-manager -emit-llvm -o /dev/null -fmemory-profile 2>&1 | FileCheck %s
// CHECK-NOT: Skipping pass
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
