hliao added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:227
+ Optional<unsigned> getAssumedAddrSpace(const Value *V) const {
+ return getTLI()->getTargetMachine().getAssumedAddrSpace(V);
----------------
hliao wrote:
> arsenm wrote:
> > We already have a -1 as an invalid addrspace, so optional isn't necessary
> OK. Do we need to document that in the IR langref? That invalid address space
> ID is not documented anywhere.
Shall we assume this before that reserved invalid address space ID is
well-received and documented in LLVM IR ref? I will make either change in this
change accordingly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91121/new/
https://reviews.llvm.org/D91121
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
