ro added a comment. In D90524#2388214 <https://reviews.llvm.org/D90524#2388214>, @glaubitz wrote:
> I think it should be good for merging now. I addressed all remarks. I'm still > convinced that "workaround" is the proper term though. Quite the contrary: the comment you cited // FIXME: This is a bit of a hack. We should really unify this code for // reasoning about oslibdir spellings with the lib dir spellings in the // GCCInstallationDetector, but that is a more significant refactoring. pretty clearly is about how/where support for that layout is implemented in the `clang` Driver code, not about the layout itself. Besides, you haven't explained why it's appropriate to no longer test support for the old (pre-Debian 9,I believe) directory layout. However, as I said I don't feel qualified to review that part, so you'll need another reviewer for that, no matter if only testing the new layout or both old and new ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
