hans added a comment.

>> I don't think it makes sense to try to emit the closure until we have the 
>> ctor definition. I'll update the patch to handle this.
>
> Ok. That's a bit different than what MSVC is doing. It generates a closure 
> constructor even if there is only a declaration. But I guess we are not 
> aligning specifically with MSVC!
> Look good.

Right, I noticed that MSVC does this, but I couldn't come up with any reason 
why it would be necessary for us. Emitting the closure with the ctor definition 
should be sufficient.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91089/new/

https://reviews.llvm.org/D91089

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to