ro added a comment.

As I'd mentioned in D90524 <https://reviews.llvm.org/D90524>, I believe both 
patches should be merged into one.  Otherwise, no matter in which order you 
commit them, the buildbots might show failures otherwise.

Another point I'm not certain about is wether the checks for the old directory 
layout should be removed: shouldn't `clang` still work correctly on both?  If 
so, both should still be tested.  However, this is something I'm not familiar 
with, so I'll leave approval to someone who is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90549/new/

https://reviews.llvm.org/D90549

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D90549: ... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D90... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D90... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D90... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D90... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D90... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D90... Rainer Orth via Phabricator via cfe-commits
    • [PATCH] D90... John Paul Adrian Glaubitz via Phabricator via cfe-commits

Reply via email to