ArcsinX added inline comments.
================ Comment at: llvm/CMakeLists.txt:604 + add_compile_options("$<$<C_COMPILER_ID:MSVC>:/utf-8>") + add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/utf-8>") else() ---------------- I think we could replace these two lines with the one line ``` add_compile_options(/utf-8) ``` Because we could not get here with non-MSVC compiler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90116/new/ https://reviews.llvm.org/D90116 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits