rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/lib/AST/ItaniumMangle.cpp:5136
+ case APValue::FixedPoint:
+ llvm_unreachable("Fixed point types are disabled for c++");
+ return;
----------------
rsmith wrote:
> rjmccall wrote:
> > Can we extract a function to do this mangling that's called from both here
> > and FixedPointLiteral, and then have that assert, rather than leaving a
> > bomb for a corner case of a corner case?
> Done. They're somewhat different cases because the other case is actually
> reachable (via `__attribute__((overloadable))`) but I think it makes sense to
> assume that we'll eventually support fixed-point in C++ mode. (I think it's a
> bit strange we didn't support it from the start.)
Agreed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89998/new/
https://reviews.llvm.org/D89998
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
