MaskRay added a comment.

> map item can be non-contiguous for target update

The subject appears to describe a situation, but patch subjects should usually 
be imperative



================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8572
       if (PartialStruct.Base.isValid())
+        CurInfo.NonContigInfo.Dims.push_back(0);
         emitCombinedEntry(CombinedInfo, CurInfo.Types, PartialStruct);
----------------
Did you forget a pair of braces?

Please verify whether f2e479db92452594dfe6aff45ab7841f0a8c69a5 is correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84192/new/

https://reviews.llvm.org/D84192

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to