bsaleil added inline comments.
================ Comment at: clang/lib/Sema/SemaChecking.cpp:10339 + if (Context.getTargetInfo().getTriple().isPPC64()) + CheckPPCMMAType(RetValExp->getType(), ReturnLoc); } ---------------- NeHuang wrote: > CheckPPCMMAType returns bool value. Do we need add it in the if condition > (similar as `CheckNonNullExpr` above) and execute a Diag()? or I may miss > something here. `CheckPPCMMAType` already emits the Diag if the type is invalid. That function also returns a bool in case the caller needs to do additional work when the type is invalid. It is not the case here, the Diag is enough so we do nothing with the result. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82035/new/ https://reviews.llvm.org/D82035 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
