arphaman marked 2 inline comments as done.
arphaman added inline comments.
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:2561-2565
// The "avx" feature changes how vectors >128 in size are passed. "avx512f"
// additionally changes how vectors >256 in size are passed. Like GCC, we
// warn when a function is called with an argument where this will change.
// Unlike GCC, we also error when it is an obvious ABI mismatch, that is,
// the caller and callee features are mismatched.
----------------
ab wrote:
> also very minor nitpick: if you pass around some WarnOnSSE bool or something,
> you'd have the darwin explanation with this psABI comment here, might be nicer
This didn't really fit well here as there's also a second invocation of
`checkAVXParam` for the return type, which would need a second check for
whether the warning is enabled or not, so I moved your suggestion into
`checkAVXParam` itself.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86105/new/
https://reviews.llvm.org/D86105
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
