nridge marked an inline comment as done.
nridge added inline comments.

================
Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:782
+
+    EXPECT_EQ(Ref1->Container, Ref2->Container);
+  };
----------------
kadircet wrote:
> can you also assert containers here are non-null (and below)
It looks like the container is null for toplevel decls. Is that a problem?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89670/new/

https://reviews.llvm.org/D89670

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to