dschuff added a comment.

Can you upload the diff with full context (e.g. use `diff -U 9999` or use 
arcanist to upload)?

I'm a bit confused; the commit message talks about X32 being a separate 
architecture, but you're not adding any new architecture triples here (it still 
uses x86_64 as the architecture and selects the ABI via the environment). 
AFAICS what really changes is that the structure of the include and lib 
directories is now multi-arch style with the x32 headers alongside the x86_64 
base headers?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52050/new/

https://reviews.llvm.org/D52050

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D52050: ... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D52... Derek Schuff via Phabricator via cfe-commits
    • [PATCH] D52... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D52... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D52... Derek Schuff via Phabricator via cfe-commits
    • [PATCH] D52... John Paul Adrian Glaubitz via Phabricator via cfe-commits

Reply via email to