rnk added inline comments.
================ Comment at: compiler-rt/lib/ubsan/ubsan_type_hash_itanium.cpp:15 #include "ubsan_platform.h" -#if CAN_SANITIZE_UB && !SANITIZER_WINDOWS +#if CAN_SANITIZE_UB && (!SANITIZER_WINDOWS || defined(__MINGW32__)) #include "ubsan_type_hash.h" ---------------- Truly, MSVC is the odd duck: I would change the condition to `!defined(_MSC_VER)`, it will work for clang and msvc. ================ Comment at: compiler-rt/lib/ubsan/ubsan_type_hash_win.cpp:15 #include "ubsan_platform.h" -#if CAN_SANITIZE_UB && SANITIZER_WINDOWS +#if CAN_SANITIZE_UB && SANITIZER_WINDOWS && !defined(__MINGW32__) #include "ubsan_type_hash.h" ---------------- Ditto, this could just be `defined(_MSC_VER)`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90571/new/ https://reviews.llvm.org/D90571 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
