kbobyrev added inline comments.
================ Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:51 + clangd_process.wait() + os.kill(index_server_process.pid, 9) + ---------------- kadircet wrote: > can we rather use `signal.SIGXXX` here instead of `9` ? > > Also rather than kill, SIGINT might be more applicable. > https://docs.python.org/3/library/signal.html#signal.SIGKILL claims sigkill > is not available on windows. The problem with `SIGINT` is that it needs to wait for the hot reload sync to finish :) I'll add a patch to modify the frequency via CLI to avoid long test terminaiton. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
