krasimir added a comment. In D90121#2361985 <https://reviews.llvm.org/D90121#2361985>, @thakis wrote:
> This doe snot lgtm. clang-format should not depend on clangFrontend, see the > lengthy discussion in https://reviews.llvm.org/D68554 . Let's try to find > another fix here (and include a test for whatever this fixes). I'll revert > this for now. Thank you Niko for the revert and the pointer to the discussion! Good to know that it is undesirable to have clang-format depend on clangFrontend! @dmikis: This constraint limits the options we have with `DiagnosticsEngine` here. A path forward may be to poke around `DiagnosticsEngine` to not crash with a `null` client; I'm unsure on the feasibility of that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/ https://reviews.llvm.org/D90121 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
