Hiralo marked 4 inline comments as done. Hiralo added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:290 DefaultOptions.Checks = DefaultChecks; + DefaultOptions.ConfigFile = ""; DefaultOptions.WarningsAsErrors = ""; ---------------- njames93 wrote: > Given you've removed the references to `ConfigFile` in `ClangTidyOptions.h` > this should surely result in a compiler error, same goes below. Thanks for heads-up and references. ================ Comment at: clang-tools-extra/test/clang-tidy/infrastructure/config-file.cpp:2 +// REQUIRES: shell +// RUN: mkdir -p %T/config-file/ +// RUN: cp %s %T/read-file-config/test.cpp ---------------- DmitryPolukhin wrote: > I think it is better to use some file in `%S/Inputs` like in > https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/test/clang-tidy/infrastructure/config-files.cpp sure... in latest update added clang-tools-extra/test/clang-tidy/infrastructure/Inputs/config-file/config-file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89936/new/ https://reviews.llvm.org/D89936 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
