JonChesterfield added inline comments.
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:4794
CGM.getModule(), LLVMStaticTy,
- /*isConstant=*/false, llvm::GlobalValue::CommonLinkage,
- llvm::Constant::getNullValue(LLVMStaticTy),
+ /*isConstant=*/false, llvm::GlobalValue::InternalLinkage,
+ llvm::UndefValue::get(LLVMStaticTy),
----------------
Perhaps weak_any + undef?
Could use internal for symbols that may vary in size and weak_any for those
that don't.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89994/new/
https://reviews.llvm.org/D89994
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
