shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land.
LGTM, this feels cleaner. ================ Comment at: clang/include/clang/Basic/SourceManager.h:721 mutable FileID LastLineNoFileIDQuery; - mutable SrcMgr::ContentCache *LastLineNoContentCache; + mutable const SrcMgr::ContentCache *LastLineNoContentCache; mutable unsigned LastLineNoFilePos; ---------------- Maybe to clarify that the mutable applies to the pointer and not the `const SrcMgr::ContentCache`: ``` using ConstContentCache = const SrcMgr::ContentCache; mutable ConstContentCache *LastLineNoContentCache; ``` debatable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89914/new/ https://reviews.llvm.org/D89914 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
