kbobyrev added inline comments.
================
Comment at: clang-tools-extra/clangd/index/remote/ProtocolVersion.h:4
+namespace remote {
+static const char *RemoteIndexProtocolVersion = "0.1.0";
+}
----------------
Not sure if having a separate file with a hard-coded string is a good idea,
should I use something like `ProtocolVersion.inc` and have a macro definition
there?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89862/new/
https://reviews.llvm.org/D89862
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
