MaskRay added a comment.

In D85474#2343356 <https://reviews.llvm.org/D85474#2343356>, @dexonsmith wrote:

> In D85474#2343326 <https://reviews.llvm.org/D85474#2343326>, @MaskRay wrote:
>
>> In D85474#2342365 <https://reviews.llvm.org/D85474#2342365>, @compnerd wrote:
>>
>>> Is there a reason to not use the existing `-mlinker-version=` option and 
>>> expanding that beyond just Darwin targets?  I feel like having the same 
>>> option would be much nicer.
>
> I agree with @compnerd that it seems better to reuse this if possible. I 
> wasn't around back then, but I have to assume it was named generically in 
> order to enable that.
>
>> `-mlinker-version` is currently a macOS option. We could reuse it but that 
>> would be confusing: when -fuse-ld=lld is specified, does it specify the lld 
>> version? (No)
>
> Maybe it should?

Then there is an expanded use case, -fuse-ld= which is just a driver option for 
linking, will now affect code generation.

>> There are also GNU as related issues.
>
> I don't understand this bit.

This is the main point. Many feature are also related to the version of GNU 
assembler when -fno-integrated-as is specified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85474/new/

https://reviews.llvm.org/D85474

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to