ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land.
For libc++: We never manually define `_LIBCPP_BUILD_STATIC`, so libc++ always contains `__shared_weak_count::__get_deleter`. For libc++abi: It could happen that `_LIBCPP_BUILD_STATIC` is defined through the CMake logic, however libc++abi always builds with RTTI enabled. So `!defined(_LIBCPP_NO_RTTI)` is always true anyway, and we always get the declaration of `__shared_weak_count::__get_deleter`. I think this is a no-op change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32838/new/ https://reviews.llvm.org/D32838 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits