sammccall added a comment. Yep, let's revert to the previous state and land that, and I'll puzzle over the examples you give (because always returning false shouldn't affect behavior, just performance).
I have put together D89785 <https://reviews.llvm.org/D89785> for more general attribute support, and it has a generalization of the fix here. (It returns `false` for any node with an attribute attached). But it's worth landing this first as it has good tests for the objc cases, and that patch has its own prerequisites and risks of regressions. (Not a timely coincidence, rather I got curious about the AST around Attrs after seeing this patch) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/ https://reviews.llvm.org/D89579 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
