JDevlieghere added inline comments.
================ Comment at: clang/include/clang/Basic/FileEntry.h:33 + +using llvm::Optional; +using llvm::StringRef; ---------------- Won't this now make `llvm::Optional` visible as `clang::Optional` everywhere this header is included? Isn't this considered bad practice in a header? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89761/new/ https://reviews.llvm.org/D89761 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
