craig.topper added inline comments.
================ Comment at: llvm/lib/Target/X86/X86InstrInfo.td:320 +def X86testui : SDNode<"X86ISD::TESTUI", + SDTypeProfile<1, 0, [SDTCisVT<0, i32>]>, [SDNPHasChain]>; ---------------- I think this should have SDNPSideEffect to match the intrinsic and to prevent reordering with CLUI/STUI in MachineIR since the TESTUI instruction will inherit properties from X86testui being used in its pattern. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89301/new/ https://reviews.llvm.org/D89301 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
