dexonsmith added a comment.

In D89488#2332998 <https://reviews.llvm.org/D89488#2332998>, @dexonsmith wrote:

> I'd still appreciate feedback on the direction, but 
> `clang/test/ClangScanDeps/modules-full.cpp` is failing (getting 
> `"<built-in>"` listed twice under `"file-deps"` for each translation unit) so 
> I'm marking this as needing changes.

Found the bug; it was pretty subtle. See https://reviews.llvm.org/D89508 for 
details.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89488/new/

https://reviews.llvm.org/D89488

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D89488: WI... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D8948... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D8948... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D8948... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D8948... Duncan P. N. Exon Smith via Phabricator via cfe-commits
    • [PATCH] D8948... Duncan P. N. Exon Smith via Phabricator via cfe-commits

Reply via email to