dberris added a comment. > Do you think we should fix this by handling the xray-never attribute in > XRayInstrumentation, or having CodeGenFunction remove the threshold if > xray-never is set?
Good catch, thanks! I think we should go with the former (handling the case in XRayInstrumentation) -- the rationale here is that when we apply the file-based always-instrument case, we ignore the "never" attribute (i.e. the "always" case overrides the "never" case). We should make sure that this case still works (if we don't have cases for that, then we should add those too). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89441/new/ https://reviews.llvm.org/D89441 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
