scott.linder added inline comments.
================
Comment at: clang/lib/Basic/Targets/NVPTX.h:47
-1, // Default, opencl_private or opencl_generic - not defined
- 5, // opencl_global
+ -1, // opencl_global
-1,
----------------
Does anyone have any thoughts on this change specifically? Is someone more
familiar with NVPTX willing to weigh in on whether it makes more sense to carry
the address space throughout the compiler explicitly and "drop" it late in the
DWARF emission, or to do what I did in the current patch (drop it early).
I would lean towards updating the patch to do the latter, but I wanted to get
feedback before plunging off to do it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88976/new/
https://reviews.llvm.org/D88976
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
