LiuChen3 added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2389 } - if (!hasRequiredFeatures(ReqFeatures, CGM, FD, MissingFeature)) + if (!llvm::all_of(ReqFeatures, [&](StringRef Feature) { + if (!CallerFeatureMap.lookup(Feature)) { ---------------- echristo wrote: > Not sure why the change here. It'd be good to be able to reuse the same code > here. What's up? Since here is no need for complex feature processing, just a simple handle here. Besides, 'hasRequiredFeatures' function has different input argument and does not handle 'MissingFeature'. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits