hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land.
LGTM with suggestion. ================ Comment at: clang/test/Layout/itanium-pack-and-align.cpp:19 // CHECK-NEXT: 1 | int y -// CHECK-NEXT: | [sizeof=8, dsize=8, align=8, -// CHECK-NEXT: | nvsize=8, nvalign=8] +// CHECK-NEXT: | [sizeof=8, dsize=8, align=8,{{( preferredalign=8,)*}} +// CHECK-NEXT: | nvsize=8, nvalign=8{{(, preferrednvalign=8)*}}] ---------------- If it works, use `?` in place of `*`. Do also for all of the other cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89064/new/ https://reviews.llvm.org/D89064 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits