MaskRay added a comment. In D89197#2323979 <https://reviews.llvm.org/D89197#2323979>, @craig.topper wrote:
> In D89197#2323946 <https://reviews.llvm.org/D89197#2323946>, @MaskRay wrote: > >> Test __LAHF_SAHF__ >> Update clang/docs/ReleaseNotes.rst >> Update clang/test/CodeGen/attr-target-x86.c to test X86.td changes. Ideally >> "target-features" should be testable with llc to have better layering > > How does attr-target-x86.c test the X86.td changes? I was wrong. `__attribute__((target("arch=...")))` cannot test features in X86.td. X86TargetParser.cpp implements the feature propagation mechanism. I have checked the introduction of cooperlake, tigerlake, sapphirerapids and many other commits to X86.td, these features are mostly under-tested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89197/new/ https://reviews.llvm.org/D89197 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
