nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM

Looking through other uses of isNoopCast(), I don't think it makes sense to 
push this change into it, as many other usages do need it to work with 
ptrtoint/inttoptr (some of them using it specifically for them). The comment 
above the function indicates that "no-op" is to be understood as "generates no 
code" here. Possibly it could do with a rename.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88979/new/

https://reviews.llvm.org/D88979

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to