aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM though I may have spotted a potential improvement (it can be handled in a follow-up if you want).
================ Comment at: clang/lib/Analysis/ExprMutationAnalyzer.cpp:61 + // below. + auto const ConditionalOperator = conditionalOperator(anyOf( + hasTrueExpression(ignoringParens(canResolveToExpr(InnerMatcher))), ---------------- Do you also want to handle the binary conditional operator (a GNU extension like `a ? : b`)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88088/new/ https://reviews.llvm.org/D88088 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
