dexonsmith requested changes to this revision.
dexonsmith added a comment.
This revision now requires changes to proceed.
Ah, I think it's because you filled in the "project" field which I think we
usually leave blank. Maybe now I can "request changes".
================
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:1981
+// This is only used when `-fno-constant-cfstrings` is given
ConstantAddress
----------------
Please drop this comment.
================
Comment at: clang/test/CodeGenObjC/ns-constant-strings.m:47
+// CHECK-NONFRAGILE: attributes #0 = { "objc_arc_inert" }
\ No newline at end of file
----------------
Please fix this missing newline.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70284/new/
https://reviews.llvm.org/D70284
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
