sepavloff marked an inline comment as done.
sepavloff added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:135
+                                         Bundler, BundlerArgs, Inputs,
+                                         InputInfo(&JA, Output.c_str())));
 }
----------------
yaxunl wrote:
> I would suggest to use `Args.MakeArgString(OutputFileName)` instead of 
> `Output.c_str()` to make sure it persists through the whole compilation.
Thank you for advice!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78902/new/

https://reviews.llvm.org/D78902

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to