rsmith added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:109 "multi-character character constant">, InGroup<MultiChar>; -def ext_four_char_character_literal : Extension< +def ext_four_char_character_literal : Warning< "multi-character character constant">, InGroup<FourByteMultiChar>; ---------------- aaron.ballman wrote: > One potential reason why we don't want to warn on this by default is that > four char codes were quite popular back in the Mac Classic days. Please also rename these diagnostics from ext_ to warn_. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
