dschuff added inline comments.
================
Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:962
+ case Triple::Wasm:
+ return Ctx->getWasmSection(Name, SectionKind::getMetadata(), utostr(Hash),
+ ~0);
----------------
dschuff wrote:
> I may add a couple more tests to this, but I did want to ask @sbc100 about
> this, since I'm not 100% sure at the uniqueID field is for.
also let me be more clear about the question here: what is `UniqueID` for, and
is it bad that I'm just passing it a number that is totally not unique?
================
Comment at: llvm/lib/MC/WasmObjectWriter.cpp:1353
if (Begin) {
WasmIndices[cast<MCSymbolWasm>(Begin)] = CustomSections.size();
- if (SectionName != Begin->getName())
----------------
sbc100 wrote:
> Just checking in the case where you were hitting this error the SectionName
> was duplicate but the `Begin` is uniquified ?
>
>
right. There's a second .debug_info section, so the name of `Begin` gets
uniquified.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88603/new/
https://reviews.llvm.org/D88603
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
