alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land.
Looks good with one more nit. I'm not sure what to do with `hasSizeOfAncestor`, we can leave it as is for now. ================ Comment at: clang-tidy/misc/SizeofExpressionCheck.cpp:47 @@ +46,3 @@ + isa<ParenExpr>(E)) { + ast_matchers::internal::Matcher<Expr> M = hasSizeOfAncestor(InnerMatcher); + return M.matches(*E, Finder, Builder); ---------------- The type here doesn't help, I'd use `auto`. http://reviews.llvm.org/D19014 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits